Make Events a separate entity in management app #3024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamiras
added
the
deployment/sql
wescopeland
reviewed
Jan 8, 2025
Comment on lines
+17
to
+18
| $table->date('active_from')->nullable(); | ||
| $table->date('active_until')->nullable(); |
There was a problem hiding this comment.
I wonder if we want indexes on both of these - I reckon they'll probably be queried against very frequently.
There was a problem hiding this comment.
Not sure if this one may have been missed.
There was a problem hiding this comment.
There are only 194 total event games in the database right now, and nothing is filtering on these values yet. I don't think one is needed, but I'm not against adding it.
There was a problem hiding this comment.
No worries, we can always add it later if it becomes needed.
app/Filament/Resources/EventResource/RelationManagers/HubsRelationManager.php
Outdated
Show resolved
Hide resolved
app/Filament/Resources/EventResource/RelationManagers/HubsRelationManager.php
Outdated
Show resolved
Hide resolved
app/Filament/Resources/EventResource/RelationManagers/HubsRelationManager.php
Outdated
Show resolved
Hide resolved
wescopeland
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a minimalistic
eventstable as suggested here. Much of the data is still managed by the underlying game/achievements objects.At this point, no
eventsrecords will exist. The following query should be run on prod after deployment:This PR also adds a new page to the management console (accessible by Event Managers and Administrators - not accessible by Developers) for editing event records. The raw game records are still editable by Developers, but the event extensions no longer appear in the achievement pages. Event achievements are also now their own resource type.
As such, we will need to ensure appropriate users are given the Event Manager role.
Additionally, I've removed all of the non-event related data from the event game and achievement player-facing pages. I've also removed the dev box from both pages, and the comments field from the achievement page. I believe the only functionality needed from the dev box is adding/removing related games, which is available through the management console.
This includes removing the ability to reset individual event achievements. The player can still reset the entire event via the Progress widget on the event page.
I have not yet migrated the "Create Event" functionality from the admin blade panel. This PR is big enough already.
If you want to populate
eventsrecords for all event games, you can run this query:But I want to try to consolidate some event games into singular event entities after #3020 (and the followup PR for displaying badges) are merged. For example http://localhost:64000/hub/3645 shows 8 event games for AotW 2019. The Bronze/Gold/Silver and # 1, # 2, # 3 games are just for awarding badges, but might require two separate events if players were awarded both. The actual event should be created in a manner similar to the commands listed here. The Spooky and Spring events would be kept separate.